[WIP] Megatron-LM specific release v2.10 rocm cherrypicks#499
Draft
sudhu2k wants to merge 2 commits intorelease_v2.10_rocmfrom
Draft
[WIP] Megatron-LM specific release v2.10 rocm cherrypicks#499sudhu2k wants to merge 2 commits intorelease_v2.10_rocmfrom
sudhu2k wants to merge 2 commits intorelease_v2.10_rocmfrom
Conversation
* Update max_fp8 value based on is_fp8_fnuz check in utils.py * Fixed and added test_cast_master_weights_to_fp8 to ci Addressed Reviews * Update copyright information. --------- Co-authored-by: Veera Gopu <veerarajasekharreddy.gopu@amd.com>
* Refactor test_cast_master_weights_to_fp8 to use executable directly without resolving symlinks, preventing potential issues with virtual environments. * Enhance test_cast_master_weights_to_fp8 for AMDGPU portability and update comments for ROCm compatibility.
sudhu2k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These cherry picks fixes some issues that's seen in Megatron-LM unit test runs.
Type of change
Checklist: